Conversation
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
==========================================
+ Coverage 71.40% 71.46% +0.06%
==========================================
Files 206 206
Lines 15057 15113 +56
==========================================
+ Hits 10751 10801 +50
+ Misses 3523 3515 -8
- Partials 783 797 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
| return 0 | ||
| } | ||
| total := SizeOfSamplesContainer | ||
| total += len(h.Samples) * util.SizeOfFloat64 |
There was a problem hiding this comment.
nit: should it be cap(h.Samples)?
and in every place where we calculate the size of a slice, do we need to take capacity into account since underlying array's memory is allocated up to its capacity?
3 participants
Description
Introduces QPR heap memory limit in order to prevent some OOMs on proxy.
Part of #373